Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle random order from ConnectorManager.Connectors #1375

Merged

Conversation

vietle-bh
Copy link
Contributor

@vietle-bh vietle-bh commented Jun 20, 2023

NOTE: The bug seems to only affects unit test projects so far, so no rush to merge before the beta deadline.

Issues addressed by this PR

Closes #1374

Used SortCollinear and its principle to sort connectors of an MEP curve based on their origin point locations.

Test files

SharePoint folder

  • Use Revit 2020 or later
  • Try pulling any cable tray by inputting its ID
  • Check the output Json file after each pull to confirm every pull produces exactly the same result. In particular, check the start and end points of the element as well as its orientation angle.

image

Changelog

Handle random order from ConnectorManager.Connectors

@vietle-bh vietle-bh added the type:bug Error or unexpected behaviour label Jun 20, 2023
@vietle-bh vietle-bh self-assigned this Jun 20, 2023
@vietle-bh vietle-bh requested a review from pawelbaran June 20, 2023 14:19
@vietle-bh vietle-bh requested a review from michal-pekacki June 20, 2023 14:20
Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the solution to this annoying problem, happy to approve 👍

@vietle-bh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 21, 2023

@vietle-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 21, 2023

@vietle-bh to confirm, the following actions are now queued:

  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit c4456b9 into develop Jun 21, 2023
@FraserGreenroyd FraserGreenroyd deleted the Revit_Toolkit-#1374-HandleRandomConnectorsOrder branch June 21, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectorManager.Connectors sometimes returns connectors in random orders
3 participants