Create.FamilyInstance - activate fix

[michal-pekacki]

NOTE: Depends on

Issues addressed by this PR

Closes #1365

Added family symbol activate to avoid crashing if not activated.

Test files

Changelog

Additional comments

[pawelbaran]

Happy with the code changes @michal-pekacki, but could you pls add the same tweak to adaptive component create method? Thanks!

[pawelbaran]

Happy to approve the changes following the review and quick testing.

[pawelbaran]

@BHoMBot check required

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check installer

There are 11 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 2 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 7 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 19 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 22 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 27 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. Renew the cache

[bhombot-ci]

@FraserGreenroyd I have updated the cache as requested.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. Renew the cache

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. Renew the cache

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. Renew the cache

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 1 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 1 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 2 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 3 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 4 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 5 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

There are 1 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check installer

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check installer

[FraserGreenroyd]

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check copyright-compliance
• check dataset-compliance
• check ready-to-merge

[travispotterBH]

@pawelbaran Was taking a look at this as part of other work and noticed that it seems that a document.Regenerate() is required after an familyInstance.Activate() to see the benefits of its use. A document.Regenerate() can only be used within a transaction. So does it make sense to cover this call here as it seems that it might give the false impression that the geometry has ben filled?

I may be misunderstanding the documentation at revitapidocs.com though.. https://www.revitapidocs.com/2023/b4e09402-f6cd-3f48-d01e-ecb87375bac5.htm

https://www.revitapidocs.com/2023/22468e2c-9772-8478-0816-c9759aa43428.htm

[pawelbaran]

I must say that I have learnt about activation status of FamilySymbol empirically so I may be wrong, but from what I reckon, the only situation it is inactive is when the family type gets loaded, but not used yet.

Regardless, this should not matter in the context of this PR: we simply make sure the symbol is active when calling Create.FamilyInstance. Also not sure if I see the problem with activation requiring transaction - creation of a Revit element needs it so we should assume that Create.FamilyInstance will always be wrapped in one.

[travispotterBH]

creation of a Revit element needs it so we should assume that Create.FamilyInstance will always be wrapped in one.

Maybe we need to add .Regenerate() into this method.

[pawelbaran]

Maybe we need to add .Regenerate() into this method.

Did you check if we need? The method works as intended from what I know.

[michal-pekacki]

.Regenerate() can freeze model for a very long time, especially models with many linked files - I would only use it if necessary.