Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit type of pulled parameters tweaked #1350

Merged

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Apr 13, 2023

Issues addressed by this PR

Closes #

Test files

On SharePoint - only parameters that are measured in units should have UnitType property assigned (particularly relevant in lower versions of Revit, where it always was UT_Number).

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Apr 13, 2023
@pawelbaran pawelbaran self-assigned this Apr 13, 2023
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 9 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 10 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 13, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 18 requests in the queue ahead of you.

Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well:

image

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 20, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check installer

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 20, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 20, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit f17833e into develop Apr 20, 2023
@pawelbaran pawelbaran deleted the Forms_Toolkit-#37-AddSupportForPrimitiveCollections branch April 20, 2023 21:04
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants