Calls to new PlanarSurface(ICurve, null) replaced with BH.Engine.Geometry.Create.PlanarSurface

[pawelbaran]

Issues addressed by this PR

Closes #1345

Test files

As in #1345, also standard procedure for pull of panels needs to be re-tested.

Changelog

Additional comments

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[pawelbaran]

@BHoMBot check core
@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core
• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[vietle-bh]

In the issue, the link for test files only links to the issue itself.

[pawelbaran]

I fixed the link @vietle-bh, test files are here.

[vietle-bh]

It worked on the test file you provide but raised some errors on the test scripts below:

Test scripts

[pawelbaran]

Oke, it sounds like we again enjoy the differences between Revit and BHoM tolerances, the latter being more strict, therefore causing errors - thank you for spotting @vietle-bh 👍 I have restored the constructors instead of Create methods where applicable (e.g. on planar face converts - no need to re-do all planarity checks etc.), the only tweak now being passing new List<ICurve> instead of null, which should eliminate the original error reported in #1345.

[pawelbaran]

@BHoMBot check compliance
@BHoMBot check core

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check core

[vietle-bh]

All tests have passed

[pawelbaran]

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check null-handling
• check serialisation
• check versioning
• check installer

There are 19 requests in the queue ahead of you.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[pawelbaran]

@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check ready-to-merge