Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from Revit to MeshElement stopped from crashing in case of invalid Revit geometry #1321

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Mar 13, 2023

Issues addressed by this PR

Closes #1319

Test files

On SharePoint

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Mar 13, 2023
@pawelbaran pawelbaran self-assigned this Mar 13, 2023
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 14, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 8 requests in the queue ahead of you.

Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected - warning has been caught:

image

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 14, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 14, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member Author

@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 14, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 44 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check installer

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check installer

@vietle-bh vietle-bh removed their request for review March 15, 2023 17:57
@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 8b19f50 into develop Mar 15, 2023
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1319-MeshElementConvertBug branch March 15, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert from Revit to MeshElement crashes in case of invalid Revit geometry
2 participants