Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ViewPlan, Sheet, Viewport and Drawing Area methods #1313

Merged
merged 20 commits into from
Mar 10, 2023

Conversation

michal-pekacki
Copy link
Contributor

@michal-pekacki michal-pekacki commented Feb 17, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #1314

Methods needed for generating views and sheets.

Test files

Changelog

Additional comments

@michal-pekacki michal-pekacki added this to the BHoM 6.1 β MVP milestone Feb 17, 2023
@michal-pekacki michal-pekacki self-assigned this Feb 17, 2023
@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Feb 17, 2023
Revit_Core_Engine/Compute/PlaceViewOnSheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Compute/PlaceViewOnSheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Compute/PlaceViewOnSheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Compute/PlaceViewOnSheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Compute/PlaceViewOnSheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments below, we should switch all BH.Engine.Base.Compute.RecordWarning call to using the $ string interpolation syntax instead of string + string + string etc. :bowtie:

Revit_Core_Engine/Compute/PlaceViewOnSheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/Sheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/Sheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewReflectedCeilingPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
@michal-pekacki michal-pekacki changed the title Add ViewPlan, Ceiling Plan, Sheet, Place View On Sheet, Drawing Area methods Add ViewPlan, Sheet, Viewport and Drawing Area methods Feb 24, 2023
Revit_Core_Engine/Create/View/Sheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/Sheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/Sheet.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewReflectedCeilingPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
@michal-pekacki michal-pekacki force-pushed the Revit_Tools-#699-ProjectSetupViewSheetGenerator branch from 6421a50 to 364a620 Compare March 6, 2023 12:59
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/IsExisting.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/IsExisting.cs Outdated Show resolved Hide resolved
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few remarks left 👍

Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewPlan.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/Viewport.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last of the last from my side 👍

Revit_Core_Engine/Query/DrawingArea.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Create/View/ViewReflectedCeilingPlan.cs Outdated Show resolved Hide resolved
pawelbaran
pawelbaran previously approved these changes Mar 8, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve from code side 👍 To be merged after functional verification.

pawelbaran
pawelbaran previously approved these changes Mar 8, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still happy with the code 👍

pawelbaran
pawelbaran previously approved these changes Mar 10, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving on the basis of previous review and the scope of the recent commit - looking forward to versioning passing this time 👍

@michal-pekacki michal-pekacki force-pushed the Revit_Tools-#699-ProjectSetupViewSheetGenerator branch from 67a9f06 to 75e673a Compare March 10, 2023 17:03
@pawelbaran
Copy link
Member

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 41 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still happy with the changes after the last commit

@pawelbaran
Copy link
Member

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check installer

@pawelbaran
Copy link
Member

@BHoMBot check serialisation
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling

There are 3 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

Please be advised that the check with reference 11917505152 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 382 additional annotations waiting, made up of 382 errors and 0 warnings.

@pawelbaran
Copy link
Member

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 10, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit d82ffe0 into develop Mar 10, 2023
@pawelbaran pawelbaran deleted the Revit_Tools-#699-ProjectSetupViewSheetGenerator branch March 10, 2023 19:15
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ViewPlan, Ceiling Plan, Sheet, Place View On Sheet, Drawing Area methods
4 participants