Revit_Core_Engine: Handle null exception on Nurbs curves in beams

[vietle-bh]

Issues addressed by this PR

Closes #1288

While waiting for Bhom_Engine to add support for Nurbs, at least let's handle the exception on the Revit side by converting nurbs curves to polylines.

Test files

On SharePoint

Changelog

• Convert Nurbs curves to polylines to handle a null exception

[vietle-bh]

@BHoMBot check code-compliance
@BHoMBot check core
@BHoMBot check documentation-compliance
@BHoMBot check null-handling
@BHoMBot check project-compliance
@BHoMBot check serialisation

[bhombot-ci]

@vietle-bh to confirm, the following actions are now queued:

• check code-compliance
• check core
• check documentation-compliance
• check null-handling
• check project-compliance
• check serialisation

[bhombot-ci]

@vietle-bh to confirm, the following actions are now queued:

• check code-compliance
• check core
• check documentation-compliance
• check null-handling
• check project-compliance
• check serialisation

There are 6 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

[vietle-bh]

@BHoMBot check versioning
@BHoMBot check installer

[bhombot-ci]

@vietle-bh to confirm, the following actions are now queued:

• check versioning
• check installer

There are 13 requests in the queue ahead of you.

[bhombot-ci]

@vietle-bh to confirm, the following actions are now queued:

• check versioning
• check installer

There are 14 requests in the queue ahead of you.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[pawelbaran]

Thanks @vietle-bh for raising this. However, this one was left on purpose after a discussion with @IsakNaslundBh. There are 2 reasons for it:

• we are trying to avoid incidental checks if a curve is nurbs inside the code for maintenance reasons - it is virtually impossible to keep track of this sort of checks, e.g. when support for nurbs curves gets added in BHoM_Engine (which actually is slowly happening thanks to @IsakNaslundBh's hobby 😉), then we would need to parse the entire code base in search for this sort of ifs, which is error prone and not very efficient
• curve tessellation may generate curves that will not make sense from the engineering perspective, so we would rather not make this decision for the user - panels are a slightly different case because it is harder to draw them by hand (especially when they have funky shapes) and they usually require manual tweaks anyways

I hope this makes sense, @IsakNaslundBh please feel free to correct me if I missed something or you disagree

[vietle-bh]

I hope this makes sense, @IsakNaslundBh please feel free to correct me if I missed something or you disagree

Sure, I'll close this PR. How about this other one?

[pawelbaran]

Sure, I'll close this PR. How about this other one?

Responded 👍