-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for converting MeshElement from revit #1275
Add method for converting MeshElement from revit #1275
Conversation
Thanks @pawelbaran . Have attempted to resolve your comments now. Also, made some other minor tweaks :) Great if you can have another look! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR without extensive testing on the basis of the code to be fully validated as a part of the wider workflow developed by @IsakNaslundBh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the latest tweak that fixes diffing - however, could you please update the title @IsakNaslundBh?
The base branch was changed.
fa60b87
to
a95de10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good now I believe - happy to approve and continue the review on other threads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of the previous review.
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of the previous review.
… DiffingENgine To enable additional ones to be set outside this method
Co-authored-by: Fraser Greenroyd <fraser.greenroyd@burohappold.com>
6ed01b1
to
9601bbe
Compare
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 24 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of previous reviews
Fix handled. Dismissing.
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@pawelbaran to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is null-handling. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10628311344 |
@FraserGreenroyd I have now provided a passing check on reference |
Issues addressed by this PR
Adds method for converting any element to MeshElement from Revit
Test files
Changelog
Additional comments