Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for converting MeshElement from revit #1275

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Adds method for converting any element to MeshElement from Revit

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Nov 16, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Nov 16, 2022
@IsakNaslundBh
Copy link
Contributor Author

Thanks @pawelbaran .

Have attempted to resolve your comments now. Also, made some other minor tweaks :) Great if you can have another look! :)

pawelbaran
pawelbaran previously approved these changes Nov 23, 2022
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR without extensive testing on the basis of the code to be fully validated as a part of the wider workflow developed by @IsakNaslundBh

pawelbaran
pawelbaran previously approved these changes Nov 25, 2022
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the latest tweak that fixes diffing - however, could you please update the title @IsakNaslundBh?

@IsakNaslundBh IsakNaslundBh changed the base branch from main to develop January 3, 2023 09:17
@IsakNaslundBh IsakNaslundBh dismissed pawelbaran’s stale review January 3, 2023 09:17

The base branch was changed.

@IsakNaslundBh IsakNaslundBh force-pushed the Revit_Utility_Engine-#578-AllowDisplayOfDiffingOfLinkedElements branch from fa60b87 to a95de10 Compare January 6, 2023 07:41
pawelbaran
pawelbaran previously approved these changes Jan 9, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good now I believe - happy to approve and continue the review on other threads.

pawelbaran
pawelbaran previously approved these changes Jan 10, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of the previous review.

@pawelbaran
Copy link
Member

@BHoMBot check compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 10, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 10, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

pawelbaran
pawelbaran previously approved these changes Jan 10, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of the previous review.

@IsakNaslundBh IsakNaslundBh force-pushed the Revit_Utility_Engine-#578-AllowDisplayOfDiffingOfLinkedElements branch from 6ed01b1 to 9601bbe Compare January 11, 2023 13:42
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 11, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 24 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of previous reviews

@IsakNaslundBh IsakNaslundBh dismissed FraserGreenroyd’s stale review January 13, 2023 07:19

Fix handled. Dismissing.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check installer

There are 12 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is null-handling.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10628311344

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10628311344

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2023

@FraserGreenroyd I have now provided a passing check on reference 10628311344 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 5244fed into develop Jan 13, 2023
@FraserGreenroyd FraserGreenroyd deleted the Revit_Utility_Engine-#578-AllowDisplayOfDiffingOfLinkedElements branch January 13, 2023 12:28
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants