-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Revit 2023 added #1250
Conversation
@pawelbaran to confirm, the following actions are now queued:
There are 24 requests in the queue ahead of you. |
@BHoMBot check installer |
@pawelbaran to confirm, the following actions are now queued:
There are 39 requests in the queue ahead of you. |
@BHoMBot check compliance |
@pawelbaran to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 29 requests in the queue ahead of you. |
The check |
The check |
The check |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best thing that will ever happen to Revit 2023 👍
Review is not sufficient for the work being reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Revit 2018 and 2021 without issues! 👍
@pawelbaran to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #1249
Test files
Standard test procedures are the main test content plus a dedicated script here.
Versions to test with most care:
Key focus areas for testing:
Changelog
Additional comments
Three main reasons for meaningful code changes in this PR, beyond simply adding the new version:
ParameterType
enum is gone, replaced withForgeTypeId
(which now encompassesUnitType
,DisplayUnitType
andParameterType
)GetSpecTypeId
method toGetDataType
SpecTypeId
class in 2021 API without nestedBoolean
,Int
,String
etc. classes added in 2022, which means that my concept of mimicking that class for older versions exercised here does not work for Revit 2021