Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Revit 2023 added #1250

Merged
merged 11 commits into from
Sep 9, 2022
Merged

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Sep 8, 2022

Issues addressed by this PR

Closes #1249

Test files

Standard test procedures are the main test content plus a dedicated script here.

Versions to test with most care:

  • one version between 2018 and 2020 (to double check if nothing breaks)
  • 2021 - this is a bridge version that suffers most by the lack of consistency in versioning of Revit API (see additional comments)
  • 2023 - new one

Key focus areas for testing:

  • handling of parameters (push new parameter definitions, update element parameters incl. parameters with units etc., pulling elements with parameters)
  • pulling structural bars and panels based on the analytical model

Changelog

Additional comments

Three main reasons for meaningful code changes in this PR, beyond simply adding the new version:

  • ParameterType enum is gone, replaced with ForgeTypeId (which now encompasses UnitType, DisplayUnitType and ParameterType)
  • renaming GetSpecTypeId method to GetDataType
  • Existence of SpecTypeId class in 2021 API without nested Boolean, Int, String etc. classes added in 2022, which means that my concept of mimicking that class for older versions exercised here does not work for Revit 2021
  • Autodesk removed some structural analytical model classes from the API without prior announcement ❤️

@pawelbaran pawelbaran added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Sep 8, 2022
@pawelbaran pawelbaran self-assigned this Sep 8, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 24 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check installer

There are 39 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 19 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 29 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran pawelbaran requested a review from vietle-bh September 8, 2022 15:44
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 9 requests in the queue ahead of you.

vietle-bh
vietle-bh previously approved these changes Sep 9, 2022
Copy link
Contributor

@vietle-bh vietle-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best thing that will ever happen to Revit 2023 👍

@FraserGreenroyd FraserGreenroyd dismissed vietle-bh’s stale review September 9, 2022 09:58

Review is not sufficient for the work being reviewed

Copy link
Contributor

@michal-pekacki michal-pekacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Revit 2018 and 2021 without issues! 👍

@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 6c26286 into main Sep 9, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1249-SupportForRevit2023 branch September 9, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Revit 2023
4 participants