Revit_Core_Engine: Element Checkout Status Query Added #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
August 25, 2022 10:12
pawelbaran
previously requested changes
Sep 2, 2022
Co-authored-by: Pawel Baran <pawel.baran@burohappold.com>
pawelbaran
reviewed
Sep 2, 2022
…om/BHoM/Revit_Toolkit into Revit_Toolkit-#1227-CheckOwnership
pawelbaran
requested changes
Sep 2, 2022
There was a problem hiding this comment.
You will start hating me soon @travispotterBH (if you have not yet)...
Co-authored-by: Pawel Baran <pawel.baran@burohappold.com>
Co-authored-by: Pawel Baran <pawel.baran@burohappold.com>
Co-authored-by: Pawel Baran <pawel.baran@burohappold.com>
Co-authored-by: Pawel Baran <pawel.baran@burohappold.com>
|
updated. Included updated error messages on null handling. |
pawelbaran
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
This PR is great now, thank you for patience @travispotterBH. Happy to approve! 🎉
|
@travispotterBH to confirm, the following actions are now queued:
There are 85 requests in the queue ahead of you. |
FraserGreenroyd
previously requested changes
Sep 2, 2022
There was a problem hiding this comment.
Can we improve the PR title for change log please before merging? Happy for this review to be dismissed once PR title is improved @travispotterBH @pawelbaran - thanks!
PR title tweaked as requested
|
@pawelbaran to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #1227
Methods have been added to support the checking of single and lists of elements for their ownership/checkout status.
Test files
Changelog
Query.ElementsOwnedByOtherUsers()Query method added in theRevit_Core_EngineforElementclassQuery.ElementsOwnedByCurrentUser()Query method added in theRevit_Core_EngineforElementclassQuery.ElementsOwnedByNone()Query method added in theRevit_Core_EngineforElementclassQuery.ElementsEditablePerCheckoutStatus()Query method added in theRevit_Core_EngineforElementclassQuery.IsOwnedByOtherUser()Query method added in theRevit_Core_EngineforElementclassQuery.IsOwnedByCurrentUser()Query method added in theRevit_Core_EngineforElementclassQuery.IsOwnedByNone()Query method added in theRevit_Core_EngineforElementclassQuery.CheckoutStatus()Query method added in theRevit_Core_EngineforElementclassModify.Checkout()Modify method added in theRevit_Core_EngineforElementclassElementOwnedByOtherUserWarning()Warning added toRevit_Core_EngineforElementclassElementOwnedByCurrentUserNote()Note added toRevit_Core_EngineforElementclassAdditional comments
Note: The methods work over a cached local version to determine ownership. They will only be as up to date at the most recently sync + reload by the user.
https://www.revitapidocs.com/2023/1a4b4bbb-060d-1f42-fbb2-ab85081f8e7f.htm
I attempted to prompted the user to reload latest via task dialog window which alerted the user to the need to reload and asked for confirmation to proceed with a reload latest. However, the reload latest fails when called from one of the methods due to an open transaction. We could possibly set some rules on the toolkits Run command for methods that modify elements to do a reload latest before initiating the transaction as a resolution to this error.