Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit_Core_Engine: Solid/Curve intersections, MEP connected elements, MEP shape queries #1245

Merged
merged 12 commits into from
Sep 9, 2022

Conversation

michal-pekacki
Copy link
Contributor

@michal-pekacki michal-pekacki commented Aug 26, 2022

Issues addressed by this PR

Closes #1244

Added method to get the intersection result between curve and solid.

Test files

Changelog

  • added ConnectedElements method to get elements connected to MEP object
  • added Shape method to get the shape of the FamilyInstance object

Additional comments

@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Aug 26, 2022
@michal-pekacki michal-pekacki added this to the BHoM 5.3 β MVP milestone Aug 26, 2022
@michal-pekacki michal-pekacki self-assigned this Aug 26, 2022
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 26, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Revit_Core_Engine/Query/Intersections.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/Intersections.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/Intersections.cs Show resolved Hide resolved
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 10 requests in the queue ahead of you.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 35 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 43 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 29, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michal-pekacki michal-pekacki changed the title Revit_Core_Engine: methods needed for Fire Damper Placement Revit_Core_Engine: Solid/Curve intersections, MEP connected elements, MEP shape queries Sep 1, 2022
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 20 requests in the queue ahead of you.

pawelbaran
pawelbaran previously approved these changes Sep 1, 2022
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of my comments were addressed, happy to approve 👍

@pawelbaran
Copy link
Member

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 1, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 6, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@michal-pekacki
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 36 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes compared to the code before rebase, happy to re-approve

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 9, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 7 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit a8d34c1 into main Sep 9, 2022
@pawelbaran pawelbaran deleted the Revit_Tools-#481-FireDamperPlacement branch September 9, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intersection method for curves and solids
2 participants