-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revit_Core_Engine: Solid/Curve intersections, MEP connected elements, MEP shape queries #1245
Conversation
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
|
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@michal-pekacki to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
There are 35 requests in the queue ahead of you. |
@michal-pekacki to confirm, the following actions are now queued:
There are 43 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
@BHoMBot check compliance |
@michal-pekacki to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my comments were addressed, happy to approve 👍
@pawelbaran to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
9271c3e
to
9114f54
Compare
@BHoMBot check required |
@michal-pekacki to confirm, the following actions are now queued:
|
@michal-pekacki to confirm, the following actions are now queued:
There are 36 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes compared to the code before rebase, happy to re-approve
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #1244
Added method to get the intersection result between curve and solid.
Test files
Changelog
ConnectedElements
method to get elements connected to MEP objectShape
method to get the shape of theFamilyInstance
objectAdditional comments