Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedElementsInView, CurveLoop Tessellate, View to Solid methods #1242

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

michal-pekacki
Copy link
Contributor

Issues addressed by this PR

Closes #1202

  • added LinkedElementsInView method to get linked elements from given view
  • added Tessalate method to convert CuveLoop to list of points
  • extend Solid method to get the Solid from ViewPlan

Test files

Changelog

Additional comments

New PR for #1231

@michal-pekacki michal-pekacki added the type:feature New capability or enhancement label Aug 22, 2022
@michal-pekacki michal-pekacki added this to the BHoM 5.3 β MVP milestone Aug 22, 2022
@michal-pekacki michal-pekacki self-assigned this Aug 22, 2022
@michal-pekacki
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 22, 2022

@michal-pekacki to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 27 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of similarity to the previous version of this PR, #1231

@pawelbaran
Copy link
Member

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 22, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

@pawelbaran pawelbaran merged commit 94ab5f8 into main Aug 22, 2022
@pawelbaran pawelbaran deleted the Security_Engine-#2887-CameraFieldOfView-REBASE branch August 22, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get the control points of the Curve Loop
2 participants