-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revit => BHoM panel convert performance improved plus minor facade panel convert bug fixed #1238
Revit => BHoM panel convert performance improved plus minor facade panel convert bug fixed #1238
Conversation
We just had a call with @enarhi and specifically tested #1236 on another test file to double check that the change did not break the existing feature. Everything looks fine, @enarhi is happy, so please review @vietle-bh and let's merge once your comments get answered 👍 |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 39 requests in the queue ahead of you. |
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
… only unique planes
b0384d2
to
def7026
Compare
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check required |
@pawelbaran to confirm, the following actions are now queued:
|
@pawelbaran to confirm, the following actions are now queued:
There are 13 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #1236
Closes #1237
Test files
On SharePoint
Worth testing the standard test procedure files too @vietle-bh
Changelog
Additional comments
The proposed performance improvement is quite complex in implementation, but I will try to explain it in a few points 🙈
Before:
After:
refObjects
to be used when the actual converts get calledIn some cases this may cut down the execution time from hours to minutes.