Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit => BHoM panel convert performance improved plus minor facade panel convert bug fixed #1238

Merged
merged 10 commits into from
Aug 23, 2022

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Aug 15, 2022

Issues addressed by this PR

Closes #1236
Closes #1237

Test files

On SharePoint
Worth testing the standard test procedure files too @vietle-bh

Changelog

  • Revit => BHoM panel convert performance improved
  • facade panel convert bug fixed

Additional comments

The proposed performance improvement is quite complex in implementation, but I will try to explain it in a few points 🙈

Before:

  • each panel element converted individually
  • temporary transaction and document regeneration done for each element separately

After:

  • each panel element converted individually
  • before any converts happen, the panel locations are being extracted and cached in refObjects to be used when the actual converts get called
  • thanks to the above, all panel locations are queried in a single call, therefore only one temporary transaction is opened for all of them

In some cases this may cut down the execution time from hours to minutes.

@pawelbaran pawelbaran requested review from enarhi and vietle-bh August 15, 2022 16:36
@pawelbaran pawelbaran self-assigned this Aug 15, 2022
@pawelbaran pawelbaran added type:bug Error or unexpected behaviour type:feature New capability or enhancement labels Aug 15, 2022
@pawelbaran
Copy link
Member Author

We just had a call with @enarhi and specifically tested #1236 on another test file to double check that the change did not break the existing feature. Everything looks fine, @enarhi is happy, so please review @vietle-bh and let's merge once your comments get answered 👍

@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 39 requests in the queue ahead of you.

Revit_Core_Engine/Query/PanelSurfaces.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/PanelSurfaces.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/PanelSurfaces.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/InsertsToIgnore.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/PanelSurfaces.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/PanelSurfaces.cs Show resolved Hide resolved
Revit_Core_Engine/Objects/SurfaceCache.cs Outdated Show resolved Hide resolved
Revit_Core_Adapter/CRUD/Read.cs Show resolved Hide resolved
Revit_Core_Adapter/CRUD/Read.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Convert/Environment/FromRevit/Panel.cs Outdated Show resolved Hide resolved
@pawelbaran pawelbaran requested a review from vietle-bh August 16, 2022 18:05
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 16, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@pawelbaran pawelbaran requested a review from vietle-bh August 18, 2022 19:15
@pawelbaran pawelbaran force-pushed the Revit_Toolkit-#1237-PanelConvertPerformance branch from b0384d2 to def7026 Compare August 22, 2022 19:21
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 22, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

vietle-bh
vietle-bh previously approved these changes Aug 23, 2022
@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@pawelbaran pawelbaran requested a review from vietle-bh August 23, 2022 08:46
@pawelbaran
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 13 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 0c56cea into main Aug 23, 2022
@pawelbaran pawelbaran deleted the Revit_Toolkit-#1237-PanelConvertPerformance branch August 23, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance of pull of panels Pull of facade elements bug
2 participants