Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Query methods for Link Names, Read-only Parameters and spatial elements' bound conditions #1220

Merged
merged 6 commits into from
Jul 27, 2022
Merged

Add Query methods for Link Names, Read-only Parameters and spatial elements' bound conditions #1220

merged 6 commits into from
Jul 27, 2022

Conversation

vietle-bh
Copy link
Contributor

@vietle-bh vietle-bh commented Jul 4, 2022 •
edited
Loading

Issues addressed by this PR

Closes #1219

  • Added an IsReadOnly property to RevitParameter
  • Added methods for querying Revit links' names
  • Added methods for querying room bounding conditions

Test files

Please use the sample model "rac_basic_sample_project" that comes with Revit, or any model that contains rooms.

Changelog

  • Added an IsReadOnly property to RevitParameter
  • Added methods for querying Revit links' names
  • Added methods for querying room bounding conditions

@vietle-bh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 4, 2022

@vietle-bh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 17 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title Revit_Toolkit: Migrate methods from ButoHappold_Revit_Toolkit Revit_Toolkit: Migrate methods Jul 4, 2022
@FraserGreenroyd FraserGreenroyd changed the title Revit_Toolkit: Migrate methods Migrate methods Jul 4, 2022
@vietle-bh vietle-bh requested a review from pawelbaran July 4, 2022 13:39
@vietle-bh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 5, 2022

@vietle-bh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 21 requests in the queue ahead of you.

pawelbaran
pawelbaran requested changes Jul 5, 2022
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points about the PR itself:

  • the title is misleading (you are not migrating methods, but adding a property, enum, methods etc.)
  • missing labels
  • the PR is currently not testable:
    • what should I do with the sample Autodesk model? how does it correspond to the 4 bound conditions that we have? I am happy not to get the answers to these questions if agree that this PR will be followed by another PR that will make RoomFromRevit and SpaceFromRevit leverage the concept that you are introducing
    • would be good to see a simple script (even working on the sample Revit model) that verifies the correct behaviour of RevitParameter.IsReadOnly

Revit_Core_Engine/Query/SpatialBoundCondition.cs Show resolved Hide resolved
Revit_oM/Parameters/RevitParameter.cs Show resolved Hide resolved
@vietle-bh vietle-bh changed the title Migrate methods Addition of utility methods Jul 5, 2022
@vietle-bh vietle-bh self-assigned this Jul 5, 2022
@vietle-bh vietle-bh added the type:feature New capability or enhancement label Jul 5, 2022
@vietle-bh vietle-bh changed the title Addition of utility methods Add utility methods Jul 5, 2022
@vietle-bh vietle-bh requested a review from pawelbaran July 5, 2022 11:39
@BHoM BHoM deleted a comment from vietle-bh Jul 5, 2022
pawelbaran
pawelbaran reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, but we are getting there 👍

Revit_Core_Engine/Modify/CopyParameters.cs Outdated Show resolved Hide resolved
Revit_Core_Engine/Query/SpatialBoundCondition.cs Outdated Show resolved Hide resolved
@vietle-bh vietle-bh requested a review from pawelbaran July 8, 2022 16:19
pawelbaran
pawelbaran requested changes Jul 19, 2022
View reviewed changes
Revit_Core_Engine/Query/LinkName.cs Show resolved Hide resolved
Revit_Core_Engine/Query/SpatialBoundCondition.cs Outdated Show resolved Hide resolved
Revit_oM/Enums/BoundCondition.cs Outdated Show resolved Hide resolved
@vietle-bh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 344 requests in the queue ahead of you.

@vietle-bh
Copy link
Contributor Author

Sorry @FraserGreenroyd , the post-build event check under project-compliance also looks like an issue in this PR...

@vietle-bh
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 20, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check project-compliance

There are 9 requests in the queue ahead of you.

pawelbaran
pawelbaran reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the code, but could you please make the PR title a bit more informative? Along the lines: Link name and spatial bound queries added along with Parameter.IsReadOnly property

@pawelbaran
Copy link
Member

Btw I agree with @vietle-bh regarding the failing project compliance check: it looks like an error on the bot side @FraserGreenroyd?

@vietle-bh vietle-bh changed the title Add utility methods Add Query methods for Link Names, Read-only Parameters and spatial elements' bound conditions Jul 20, 2022
@vietle-bh
Copy link
Contributor Author

I am happy with the code, but could you please make the PR title a bit more informative? Along the lines: Link name and spatial bound queries added along with Parameter.IsReadOnly property

Thanks. I have changed the PR name now.

@vietle-bh
Copy link
Contributor Author

Btw I agree with @vietle-bh regarding the failing project compliance check: it looks like an error on the bot side @FraserGreenroyd?

Thanks @pawelbaran . FYI, I also currently have this same bug(?) on 3 other PRs here, here and here.

@vietle-bh
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 22, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member

@BHoMBot check installer
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 25, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check installer
  • check copyright-compliance
  • check dataset-compliance

There are 11 requests in the queue ahead of you.

@vietle-bh
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 25, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check installer

There are 9 requests in the queue ahead of you.

@vietle-bh
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 26, 2022

@vietle-bh to confirm, the following actions are now queued:

  • check project-compliance

@pawelbaran
Copy link
Member

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 27, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check installer

There are 3 requests in the queue ahead of you.

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 27, 2022

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 7 requests in the queue ahead of you.

@pawelbaran pawelbaran merged commit 516361c into main Jul 27, 2022
@pawelbaran pawelbaran deleted the BuroHappold_Revit_Toolkit-#475-AddSpacePlacementModule branch July 27, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbaran pawelbaran pawelbaran approved these changes

Assignees

@vietle-bh vietle-bh

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revit_Toolkit: Add methods for querying Revit link names and room bounding conditions
2 participants
@vietle-bh @pawelbaran