Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem When Pushing Loads with and LoadCase which has alreacy been defined in RFEM6 #93

Conversation

Arne-Martensen
Copy link
Contributor

@Arne-Martensen Arne-Martensen commented Jun 27, 2024

NOTE: Depends on

Issues addressed by this PR

Push of Loads with and already existin LoadCase with an equivalent Nature results in an error messages and in the Load not beeing pushed into RFEM6.

Another minor issue that has been fixed was that the pull of nodal reactions was not possible from Excel due to some impossible casting to string. This has been taken care of.

Closes #92
Closes #94

Comparars for both LoadCases well as Section have been modifies. For the Testing please just Push all gemetrical elements and after that push all loads. The result should be Geometry in RFEM6 and Loads plus appopriatly names and numberated Loadcasese.

Please Try to read nodal loads from Both the GH file and the Excel File.

Test files

Link GH Script
Link Excel File

Changelog

  • Alteration of Comparer for Loadcases
  • Alteration of Comparer for Sections

@Arne-Martensen Arne-Martensen added severity:medium Slows progress, but workaround is possible size:M Measured in hours labels Jun 27, 2024
@Arne-Martensen Arne-Martensen requested a review from Kar-Myl June 27, 2024 13:34
@Arne-Martensen Arne-Martensen self-assigned this Jun 27, 2024
@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jun 27, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Arne-Martensen Arne-Martensen marked this pull request as ready for review June 27, 2024 13:36
@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Jun 27, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check installer
  • check core
  • check serialisation
  • check null-handling

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jun 28, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check versioning

There are 46 requests in the queue ahead of you.

Kar-Myl
Kar-Myl previously approved these changes Jun 28, 2024
Copy link
Contributor

@Kar-Myl Kar-Myl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided grasshopper file was used in order to first push the geometry followed by multiple load cases. Pushing multiple load cases when loads were already present did not lead to errors.
Later the pushed loads were pulled and nodal reactions were verified for multiple load cases.

Code was not reviewed.

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check compliance

Copy link
Contributor

@Kar-Myl Kar-Myl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided grasshopper file was used in order to first push the geometry followed by multiple load cases. Pushing multiple load cases when loads were already present did not lead to errors.
Later the pushed loads were pulled and nodal reactions were verified for multiple load cases.

Code was not reviewed.

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jun 29, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Jun 29, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check installer
  • check core
  • check serialisation
  • check null-handling

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jun 29, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check versioning

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 29, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check ready-to-merge

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 29, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check ready-to-merge

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 1, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check ready-to-merge

@Arne-Martensen Arne-Martensen added the type:bug Error or unexpected behaviour label Jul 1, 2024
@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 1, 2024

@Arne-Martensen to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit 7fc3761 into develop Jul 1, 2024
12 checks passed
@peterjamesnugent peterjamesnugent deleted the RFEM&_Toolkit-#92-PushOfLoadwithExistingLoadCaseCausesError branch July 1, 2024 09:06
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:medium Slows progress, but workaround is possible size:M Measured in hours type:bug Error or unexpected behaviour
Projects
None yet
3 participants