Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 Deployment #103

Merged
merged 2 commits into from
Dec 19, 2024
Merged

8.0 Deployment #103

merged 2 commits into from
Dec 19, 2024

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Dec 9, 2024

RFEM6_Toolkit

Compliance

Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

Copy link

bhombot-ci bot commented Dec 12, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 12, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I am now running force checks on the checks requested. These will be queued and actioned ASAP.

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I have provided force checks to the checks requested.

Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM_Engine

Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM_Engine

Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoMAnalytics_Toolkit

Copy link

bhombot-ci bot commented Dec 16, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Revit_UI

Copy link

bhombot-ci bot commented Dec 16, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_Schematic_Tool

@bhombot-ci bhombot-ci bot added the type:feature New capability or enhancement label Dec 16, 2024
Copy link

bhombot-ci bot commented Dec 17, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Revit_Tagging_Tool

@Chrisshort92 Chrisshort92 self-requested a review December 17, 2024 17:14
Copy link

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @Arne-Martensen "The testing has been conducted by running the push and pull of structural elements, creating, reading, and updating properties, and creating, reading, and loading scripts. However, as the update has not been implemented yet, the testing did not include the update.

The testing of the create, read, and update scripts worked without major issues.

When testing the push and pull of properties, I replaced the sections with my own definitions, as there were some issues with the ones provided. However, all except the round section worked as expected, with the exception that not all were pulling a corresponding section but rather an 'explicit' section.

The push and pull of loads also worked as anticipated, with the only limitation being that I had to replace the material of the panel with a standard concrete from the BHoM dataset.

Testing has been conducted with the artefact:
(Open Version)BHoM_8.0.241211.beta.0 for the elements and properties, and BHoM_8.0.241213.beta.0 for the loads.

(Closed Version)
BuroHappold_BHoM_8.0.241213.beta.0"

PR to be approved based on successful test.

Copy link

bhombot-ci bot commented Dec 19, 2024

@BHoMBot just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh merged commit 1b118fd into main Dec 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants