Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UseAdapterId to false to maintain functionality of toolkit with latest Adapter Cache changes #217

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Mar 20, 2023

Issues addressed by this PR

Closes #215

Set UseAdapterId to false so toolkit functionality works without throwing breaking errors due to new Cache method AdapterId handling.

Test file(s):

test scrpt

@enarhi enarhi self-assigned this Mar 20, 2023
@enarhi enarhi added the type:bug Error or unexpected behaviour label Mar 20, 2023
@enarhi
Copy link
Member Author

enarhi commented Mar 20, 2023

@BHoMBot check compliance

@enarhi enarhi requested a review from LukeBastianBH March 20, 2023 21:14
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 20, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Co-authored-by: Isak Näslund <isak.naslund@burohappold.com>
Copy link

@LukeBastianBH LukeBastianBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing and updating structural elements successfully as detailed in section 1 of the Structural Adapter Testing Procedure document.

@enarhi
Copy link
Member Author

enarhi commented Mar 21, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member Author

enarhi commented Mar 21, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 3 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member Author

enarhi commented Mar 21, 2023

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 21, 2023

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

There are 20 requests in the queue ahead of you.

@enarhi enarhi merged commit e745c02 into develop Mar 21, 2023
@enarhi enarhi deleted the RAM_Toolkit-#215-FixAdapterIdDependancy branch March 21, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure on push due to Adapter Cache method key error
3 participants