Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python code to nuspec as content files #148

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #146

See the nuspec file for LadybugTools_Toolkit as an example and compare to changes made here.
As python bhom analytics now exists in Python_Toolkit code, this must be included in the nuspec content files as well.
(not to mention future additions to Python_Toolkit python code)

Test files

Likely will have to merge this then see if the bot produces nugets that contain the python files first

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Nov 13, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Nov 13, 2024
@Tom-Kingstone Tom-Kingstone marked this pull request as ready for review November 13, 2024 08:54
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check copyright-compliance

There are 9 requests in the queue ahead of you.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer

There are 32 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

There are 36 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Nov 13, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

There are 57 requests in the queue ahead of you.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 13, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 51 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh merged commit ab59437 into develop Nov 13, 2024
10 checks passed
@jamesramsden-bh jamesramsden-bh deleted the Python_Toolkit-#146-UpdateNuspec branch November 13, 2024 14:38
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nuspec file to include python library
2 participants