Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo_Adapter: type requests fixed to return all subtypes instead of exact type matches #167

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Dec 20, 2022

NOTE: Depends on

BHoM/BHoM_Engine#2965

Issues addressed by this PR

Closes #166

Test files

On SharePoint

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Dec 20, 2022
@pawelbaran pawelbaran self-assigned this Dec 20, 2022
@pawelbaran pawelbaran requested a review from alelom December 20, 2022 13:35
@FraserGreenroyd FraserGreenroyd changed the base branch from main to develop December 21, 2022 10:11
@FraserGreenroyd FraserGreenroyd changed the base branch from develop to main December 21, 2022 10:11
@pawelbaran pawelbaran changed the base branch from main to develop January 3, 2023 09:36
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@pawelbaran pawelbaran force-pushed the Reflection_Engine-#2964-SubtypesQuery branch from 8a74f37 to b62bea6 Compare January 9, 2023 18:20
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 9, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test review to check merge status - DO NOT MERGE

@FraserGreenroyd FraserGreenroyd dismissed their stale review January 10, 2023 09:17

Merge is fine - dismissing review

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on code inspection and valid BsonDocuments being produced when converting a FilterQuery with this PR

@adecler adecler merged commit ee69975 into develop Jan 10, 2023
@adecler adecler deleted the Reflection_Engine-#2964-SubtypesQuery branch January 10, 2023 11:23
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongo_Adapter: Type requests return exact type matches
3 participants