Shallow clone BarVaryingDistributedLoad so the returned objects are not modified

[peterjamesnugent]

Issues addressed by this PR

Closes #274

Test files

#274 BarVaryingDistributedLoad

Changelog

• Changed how BarVaryingDistributedLoads are created to remove any modification of the base object;

[KalleEdstroem]

Looking at some of the similar CRUD methods they look quite similar. Could the same issue be present in those as well or has that been ruled out ? In that case a similar change should be implemented for those.

MidasCivil_Toolkit/MidasCivil_Adapter/CRUD/Create/Loads/BarUniformlyDistributedLoads.cs

Lines 39 to 43 in ebe9abd

	private bool CreateCollection(IEnumerable<BarUniformlyDistributedLoad> barUniformlyDistributedLoads)
	{
	string loadGroupPath = CreateSectionFile("LOAD-GROUP");
	foreach (BarUniformlyDistributedLoad barUniformlyDistributedLoad in barUniformlyDistributedLoads)

MidasCivil_Toolkit/MidasCivil_Adapter/CRUD/Create/Loads/BarUniformlyDistributedLoads.cs

Lines 60 to 63 in ebe9abd

	for (int i = 0; i < 6; i++)
	{
	barUniformlyDistributedLoad.Force = zeroVector;
	barUniformlyDistributedLoad.Moment = zeroVector;

[peterjamesnugent]

@BHoMBot check compliance

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[KalleEdstroem]

Tested using test script provided. Gives same values for loads from original, push and pull components for:

• AreaUniformlyDistributedLoads
• BarPointLoad
• BarUniformlyDistributedLoads
• BarVaryingDistributedLoad

[peterjamesnugent]

@BHoMBot check required

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[peterjamesnugent]

@BHoMBot check ready-to-merge

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check ready-to-merge