Added merging tolerance within LusasConfig to apply to both the comparers and the software

[KalleEdstroem]

Issues addressed by this PR

Closes #315

Added a feature to set the Merge Tolerance.
The property is set in the LusasConfig. and the merge tolerance gets set when the adapter is activated.

Test files

Initialize adapter with and without LusasConfig.

Versioning test script. Start without building and inspect. Build and inspect upgrades.

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Lusas_Toolkit/%23315-ModifyMergingTolerance?csf=1&web=1&e=Szf9WG

Changelog

• Added variable, MergeTolerance to the LusasConfig component. Added referance to Geometry_oM in LusasConfig to use Tolerance class for default value of MergeTolerance. Added description about the variable to the component.
• The change lets you, with the LusasConfig, set a value for Merge Tolerance in Lusas upon opening a model with the LusasAdapter.

Additional comments

The default value is set to Tolerance.Distance .

For testing of versioning it is needed to build the Versioning_Toolkit after building this branch.

[KalleEdstroem]

Should change mergingTolerance to mergeTolerance. To stay consistent with previous change made

[peterjamesnugent]

Tested with the script and it works changing the merging tolerance in Lusas.

Have commented some changes below to implement.

[peterjamesnugent]

Changes as discussed.

[peterjamesnugent]

Tested with Lusas v19, v19.1 and v20 using the test script.

Small change to give the m_mergingTolerance a default value when it is initialised.

[peterjamesnugent]

Two changes to descriptions

[peterjamesnugent]

Happy with the changes, tested with the versioning script and test script.

Happy to accept that any internalised LusasConfig objects will not version - as they previously only contained a string for library settings, I highly doubt they were being used anywhere .

[peterjamesnugent]

@BHoMBot check required

[bhombot-ci]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[peterjamesnugent]

@FraserGreenroyd can we get a neutral check on the versioning result please. There is a lot of Revit noise but one relevant to this PR:

    BH.oM.Adapters.Lusas.LusasConfig
    Error: Result returned as CustomObject
    Inner results:
        Failed to convert the string into a type: BH.oM.Adapters.Lusas.LusasConfig
        The type BH.oM.Adapters.Lusas.LusasConfig from version 6.3 is unknown -> data returned as custom objects.

Which is as intended due to the change from BHoMObject to IObject.

[FraserGreenroyd]

@BHoMBot check versioning

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check versioning

[FraserGreenroyd]

@BHoMBot check installer

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check installer

[FraserGreenroyd]

@FraserGreenroyd can we get a neutral check on the versioning result please. There is a lot of Revit noise but one relevant to this PR:

    BH.oM.Adapters.Lusas.LusasConfig
    Error: Result returned as CustomObject
    Inner results:
        Failed to convert the string into a type: BH.oM.Adapters.Lusas.LusasConfig
        The type BH.oM.Adapters.Lusas.LusasConfig from version 6.3 is unknown -> data returned as custom objects.

Which is as intended due to the change from BHoMObject to IObject.

As discussed offline, dispensation for versioning checks aren't available because if a versioning issue is merged, it will then report failures on every pull request we have. The issue here was caused by the branch on Versioning_Toolkit still existing (despite PR being closed) from when we were looking at upgrading the object. I've deleted the branch over there and it looks like that's now fixed the versioning issues here 😄

[FraserGreenroyd]

@BHoMBot check copyright-compliance

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check copyright-compliance

My changes were made so all happy from my side.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge