Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BHoMAdapter inheritance for LusasV191Adapter #363

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #362

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Aug 16, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Aug 16, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 7 requests in the queue ahead of you.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested each of the adapter (v17, v18, v19, v191 and v20) and happy they all work - pushed a few elements and properties as a quick verification.

@peterjamesnugent
Copy link
Member

@BHoMBot check versioning
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check versioning
  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 41dc4b7 into develop Aug 17, 2023
@FraserGreenroyd FraserGreenroyd deleted the Lusas_Toolkit-#362-Adapter branch August 17, 2023 10:53
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LusasV191Adapter does not inherit from BHoMAdapter
2 participants