-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the way Edges are handled and duplication of code #355
Update to the way Edges are handled and duplication of code #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested Lusas_Toolkit with test script provided and the bug has been fixed. All elements have been pushed correctly, as well as ID allocation and loading.
I have not reviewed the code.
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes approved. I have carried out additional checks for panels that dont share edges and also panels with more than 3 edges.
@peterjamesnugent to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #354
Fixed bug where specific
Panel
objects sharing anEdge
would not push due to theEdge
being culled.Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23354%20Panels%20sharing%20an%20Edge%20do%20not%20push%20correctly.gh?csf=1&web=1&e=57fy5M
Changelog
Fixed bug where specific
Panel
objects sharing anEdge
would not push due to theEdge
being culled.Additional comments
See https://github.com/BHoM/Lusas_Toolkit/wiki/Lusas-Specific-Adapter-Features#starting-the-adapter for how to start the Adapter.
You will need to refresh the mesh to view the loads.