Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the way Edges are handled and duplication of code #355

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Jun 27, 2023

Issues addressed by this PR

Closes #354

Fixed bug where specific Panel objects sharing an Edge would not push due to the Edge being culled.

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/Lusas_Toolkit/%23354%20Panels%20sharing%20an%20Edge%20do%20not%20push%20correctly.gh?csf=1&web=1&e=57fy5M

Changelog

Fixed bug where specific Panel objects sharing an Edge would not push due to the Edge being culled.

Additional comments

See https://github.com/BHoM/Lusas_Toolkit/wiki/Lusas-Specific-Adapter-Features#starting-the-adapter for how to start the Adapter.
You will need to refresh the mesh to view the loads.

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Jun 27, 2023
@peterjamesnugent peterjamesnugent self-assigned this Jun 27, 2023
Copy link

@martin-rivas-quarneti martin-rivas-quarneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested Lusas_Toolkit with test script provided and the bug has been fixed. All elements have been pushed correctly, as well as ID allocation and loading.

I have not reviewed the code.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@StephennipBH StephennipBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved. I have carried out additional checks for panels that dont share edges and also panels with more than 3 edges.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 28, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit ba19c29 into develop Jun 28, 2023
@peterjamesnugent peterjamesnugent deleted the Lusas_Toolkit-354-PanelsSharingAnEdge branch June 28, 2023 12:46
@peterjamesnugent peterjamesnugent changed the title Lusas_Toolkit: Update to the way Edges are handled and duplication of code Update to the way Edges are handled and duplication of code Jun 30, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lusas_Toolkit: Panels sharing an Edge do not push correctly
3 participants