Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Units_oM reference to project reference #79

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Change Units_oM reference to project reference #79

merged 1 commit into from
Aug 17, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #78

Fixing the way the Units_oM is referenced in Units_Engine

Test files

No real testing required as long as installer is passing. If testing is to be made, the following files can be used:

https://burohappold.sharepoint.com/:f:/s/BHoM/EnZR9EeVJXdCk2ijRNEVPWoBLo7cNmgAGsAnZaxh2piLMw?e=TqdAG1

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Aug 16, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Aug 16, 2022
@IsakNaslundBh IsakNaslundBh requested a review from tg359 as a code owner August 16, 2022 08:49
pawelbaran
pawelbaran approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy as long as the bot is happy 👍

FraserGreenroyd
FraserGreenroyd approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable fix, approved from code review.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 17, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 545016b into main Aug 17, 2022
@IsakNaslundBh IsakNaslundBh deleted the Localisation_Toolkit-#78-ChangeUnitsOmReferenceInUnitsEngine branch August 17, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbaran pawelbaran pawelbaran approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Units_oM is referenced as dll in programdata rather than as project reference
3 participants
@IsakNaslundBh @FraserGreenroyd @pawelbaran