-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Boverket datasets #360
Update Boverket datasets #360
Conversation
@BHoMBot check installer |
@michaelhoehn to confirm, the following actions are now queued:
|
@BHoMBot check required |
@michaelhoehn to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the script, looks good.
@BHoMBot check compliance |
@michaelhoehn to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@michaelhoehn to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #359
Test files
To test:
Test API call and convert from custom objects to dataset: test file
Changelog
Additional comments
Once consensus has been reached with this dataset, I would suggest we remove the legacy dataset, but due to underlying dependencies I have chosen to leave it in place.
Note I have not validated any numbers and have only pulled their data using their API. I have captured their A1-A3, A4, and A5.1 (as A5 because we don't support subcategories) for both conservative figures and typical figures (only affecting A1-A3 from what I can tell). These values should be tested and validated by the community.