Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Boverket datasets #360

Merged

Conversation

michaelhoehn
Copy link
Contributor

@michaelhoehn michaelhoehn commented Nov 26, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #359

Test files

To test:

  1. Create a new dataset primitive
  2. Right click search and select LifeCycleAssessment > Boverket > select one of the two new datasets and repeat
  3. Verify functionality

Test API call and convert from custom objects to dataset: test file

Changelog

Additional comments

Once consensus has been reached with this dataset, I would suggest we remove the legacy dataset, but due to underlying dependencies I have chosen to leave it in place.

Note I have not validated any numbers and have only pulled their data using their API. I have captured their A1-A3, A4, and A5.1 (as A5 because we don't support subcategories) for both conservative figures and typical figures (only affecting A1-A3 from what I can tell). These values should be tested and validated by the community.

@michaelhoehn michaelhoehn added the type:feature New capability or enhancement label Nov 26, 2024
@michaelhoehn michaelhoehn self-assigned this Nov 26, 2024
@michaelhoehn
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 26, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check installer

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 3, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

@GryHaxholm-BH GryHaxholm-BH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the script, looks good.

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Dec 3, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 3, 2024

@michaelhoehn to confirm, the following actions are now queued:

  • check ready-to-merge

@michaelhoehn michaelhoehn merged commit 256bd49 into develop Dec 3, 2024
12 checks passed
@michaelhoehn michaelhoehn deleted the LifeCycleAssessment_Toolkit-#359-Boverket-Update branch December 3, 2024 17:43
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the Boverket database using their API
2 participants