Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEP Environmental Product Declaration Dataset Update #336

Merged

Conversation

kayleighhoude
Copy link
Member

Updated MEP EPD Dataset

NOTE: Depends on

Issues addressed by this PR

The following problems: were addressed:
-The VAV EPD needs to be corrected to 1580.4 GWP (x 3600 to correct for seconds in an hour), the description also needs to be modified
-The transformer EPD needs to be removed, the panel EPD should be used when a local transformer needs to be evaluated
-A description should be added for Steel Conduit Sizing (changed to Conduit)
-A description should be added for Pipe Valve Sizing

Closes #335

Test files

Changelog

Additional comments

Updated MEP EPD Dataset
Copy link

@shivanierambaran shivanierambaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed - scaling factors are clearly called out in descriptions and reflect information and functional units from the EPDs and/or product information.
A change requested is replacing the lifespans of 0 with either default building life (60 years) or another suitable life span. This is so that there are no errors when calculations are made for replacement emissions.

@kayleighhoude
Copy link
Member Author

@shivanierambaran all lifespan data now included per your request, used ASHRAE data when possible (citing that reference in the description)

Copy link

@shivanierambaran shivanierambaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving dataset after lifespans fix.

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Aug 23, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 93ad9e8 into develop Aug 23, 2023
@FraserGreenroyd FraserGreenroyd deleted the LifeCycleAssessment_Toolkit-#336-MEPEPDUpdate branch August 23, 2023 20:11
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MEP EPD Dataset Fixes
3 participants