-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UK/EU Facades Datasets #281
Added UK/EU Facades Datasets #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes are summarized in the test script saved here:
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/LifeCycleAssessment_Toolkit/%23279-EU%20Facade%20Datasets/220721_Check%20EPD%20Datasets_With%20Comments.gh?csf=1&web=1&e=ae5CME
@BHoMBot check dataset-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot checked items from each new dataset using test script saved at link below. All dataset items checked included the necessary information.
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/LifeCycleAssessment_Toolkit/%23279-EU%20Facade%20Datasets/220721_Check%20EPD%20Datasets_With%20Comments.gh?csf=1&web=1&e=ae5CME
@BHoMBot check required |
@enarhi to confirm, the following actions are now queued:
|
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check dataset-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check dataset-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
I have neutralised the check as the check was reporting a success via the bot (viewed on the bot itself) but is failing to report to GitHub, an issue unrelated to this PR. |
Issues addressed by this PR
Closes #279
Added generic EU/UK EPD datasets, such as: Insulation, metal, glass, stone and other materials
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/LifeCycleAssessment_Toolkit/%23279-EU%20Facade%20Datasets/Test%20EU%20generic%20EPD%20datasets.gh?csf=1&web=1&e=yNfvxy