Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing apostrophe in GetMaterial description #88

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Removing apostrophe in GetMaterial description #88

merged 1 commit into from
Jan 12, 2023

Conversation

kprusicka
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #78

Apostrophe removed.

Test files

Changelog

Additional comments

@kprusicka kprusicka added the type:documentation Wiki, help or in code attributes label Jan 12, 2023
@kprusicka kprusicka self-assigned this Jan 12, 2023
@kprusicka
Copy link
Contributor Author

@BHoMBot Check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

@kprusicka to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@kprusicka kprusicka requested a review from CKBoulter January 12, 2023 15:56
FraserGreenroyd
FraserGreenroyd approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and meets the objective

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Jan 12, 2023 •
edited
Loading

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests
  • check dataset-compliance
  • check copyright-compliance
  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 21e26ea into develop Jan 12, 2023
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#78-RemovingApostrophe branch January 12, 2023 16:34
@kprusicka
Copy link
Contributor Author

Thank you @BHoMBot

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

@kprusicka you're very welcome! 😄

@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359

@jamesramsden-bh jamesramsden-bh Awaiting requested review from jamesramsden-bh

@CKBoulter CKBoulter Awaiting requested review from CKBoulter

Assignees

@kprusicka kprusicka

Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove apostrophe in GetMaterial description
2 participants
@kprusicka @FraserGreenroyd