Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more predefined comfort categories, and heatmap_histogram method #260

Merged

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Nov 7, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #259

Add a few more predefined thermal comfort categories, and a method to plot ComfortCategory related pandas Series as heatmap/histogram combo charts.

Test files

See the changes in the pytest file for methods checking that these work.

Changelog

Additional comments

@tg359 tg359 added good first issue Good for newcomers severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:feature New capability or enhancement priority:low Resources should be targeted to other issues first labels Nov 7, 2024
@tg359 tg359 self-assigned this Nov 7, 2024
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All python tests passing, and created a few heatmaps, histograms and heatmap_histograms myself from the new categories, and they all work as expected.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 7, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@tg359 tg359 requested a review from msandmer November 8, 2024 14:29
@Tom-Kingstone
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

There are 46 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 13, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

There are 66 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh merged commit 10f8524 into develop Nov 13, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#259-AddCategoricalMethods branch November 13, 2024 12:42
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority:low Resources should be targeted to other issues first severity:low Doesn't stop/slow current workflow size:S Measured in minutes type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more Categorical methods
3 participants