Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python toolkit #142 python environment refactor #253

Merged

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on BHoM/Python_Toolkit#145

Issues addressed by this PR

Closes #

See the linked PR for more info.

Moved bhom analytics to Python_Toolkit, and updated based on changes in the linked PR

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Oct 1, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Oct 1, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Oct 1, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

Copy link

bhombot-ci bot commented Oct 1, 2024

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 1, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

1 similar comment
Copy link

bhombot-ci bot commented Oct 1, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 2, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 2, 2024

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 9, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted everything in PythonEnvironments folder. Checked out Python_Toolkit-#142-PythonEnvironmentRefactor and rebuilt required toolkits and installed BasePythonEnvionrment (version v3.10). Then launched open a script in Jupyter utilising LadybugTools_Toolkit in which all successfully ran.

Note: There was one error of "cannot import name 'utci_shade_benefit' from 'ladybugtools_toolkit.plot.spatial_heatmap'" however I think this is an outdated method from an old script therefore not current issue.

Overall, successful.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Oct 22, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling
  • check serialisation
  • check unit-tests

There are 14 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Oct 22, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 22, 2024

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 29, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

1 similar comment
Copy link

bhombot-ci bot commented Oct 29, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 29, 2024

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 29, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 29, 2024

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 30, 2024

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Oct 30, 2024

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Nov 6, 2024

@Tom-Kingstone just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

@jamesramsden-bh jamesramsden-bh merged commit db86acc into develop Nov 6, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the Python_Toolkit-#142-PythonEnvironmentRefactor branch November 6, 2024 15:24
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants