-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reference before assignment on utci heatplot generation #247
Fix reference before assignment on utci heatplot generation #247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with LadybugTools_Toolkit_TestScript.gh
and all test run successfully return True
. Happy to approve these changes.
@BHoMBot check core |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 505 requests in the queue ahead of you. |
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 767 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a very sensible change
NOTE: Depends on
Issues addressed by this PR
Closes #246
replaced use of
base64
withsave_path
when asking to save the plotsTest files
Test using the current beta test script
Changelog
Additional comments
ensure you don't count the test done off this PR as a beta artefact test