Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference before assignment on utci heatplot generation #247

Merged

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #246

replaced use of base64 with save_path when asking to save the plots

Test files

Test using the current beta test script

Changelog

Additional comments

ensure you don't count the test done off this PR as a beta artefact test

@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Sep 10, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Sep 10, 2024
Copy link

@Felix-Mallinder Felix-Mallinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with LadybugTools_Toolkit_TestScript.gh and all test run successfully return True . Happy to approve these changes.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core

Copy link

bhombot-ci bot commented Sep 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core

There are 505 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Sep 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 767 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Sep 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Sep 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer
  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Sep 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 10, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a very sensible change

@jamesramsden-bh jamesramsden-bh merged commit dd6f485 into develop Sep 10, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#246-FixReferenceError branch September 10, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter method failing during beta testing
3 participants