-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change matplotlib backend to GUI-less for wrapped methods #244
Change matplotlib backend to GUI-less for wrapped methods #244
Conversation
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 29 requests in the queue ahead of you. |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the test file and successfully produced the 5 output images. Continued to be successful when testing with different inputs. Happy to approve this works.
@BHoMBot check ready-to-merge |
@Tom-Kingstone to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #241
Changed matplotlib backend for all wrapped methods where plots are generated to use a non-GUI backend (
Agg
)Also added
IObject
interface to SunData so that it can be serialised using the BHoM serialiser properly.Test files
Test that running each of the execute commands for the wrapped methods still produces the plots as expected.
LBT 241.zip
Changelog
Additional comments