Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change matplotlib backend to GUI-less for wrapped methods #244

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Aug 30, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #241

Changed matplotlib backend for all wrapped methods where plots are generated to use a non-GUI backend (Agg)
Also added IObject interface to SunData so that it can be serialised using the BHoM serialiser properly.

Test files

Test that running each of the execute commands for the wrapped methods still produces the plots as expected.
LBT 241.zip

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Aug 30, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Aug 30, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Sep 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Sep 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests

There are 29 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

Copy link

bhombot-ci bot commented Sep 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

Copy link

@Felix-Mallinder Felix-Mallinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the test file and successfully produced the 5 output images. Continued to be successful when testing with different inputs. Happy to approve this works.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 9, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 91e2751 into develop Sep 10, 2024
12 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#241-MatplotlibBackend branch September 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change backend for matplotlib for bhom/wrapped/plot methods
3 participants