Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wet Bulb Temperature to EPW Keys #235

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #229

Updated the enum, and added logic to wrapped methods to handle calculating a wet bulb temperature collection from the epw file.

Test files

LBT_229_test.zip
Check that the wet bulb temperature is correctly calculated, and check that normal epw keys aren't broken

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Aug 2, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Aug 2, 2024
@Tom-Kingstone Tom-Kingstone linked an issue Aug 2, 2024 that may be closed by this pull request
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Aug 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests
  • check serialisation
  • check null-handling

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

Copy link

bhombot-ci bot commented Aug 2, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Aug 2, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating plots correctly, all fine

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 2, 2024

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 17 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh merged commit 4497685 into develop Aug 12, 2024
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#229-WetBulbTemperature branch August 12, 2024 08:31
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Wet Bulb Temperature to EPWKey Enum
2 participants