Fixed python Materials enum invalid keys

[Tom-Kingstone]

NOTE: Depends on

Issues addressed by this PR

Closes #213

When creating the enum, instead of calling sanitise_string, it calls the new method get_identifier which behaves similarly to sanitise_string, except it also excludes -, . and prepends _ when the identifier starts with a number.

Test files

try to get a material using the enum as follows:

from ladybugtools_toolkit.external_comfort.material import Materials
Materials.Material_12_in_Normalweight_Concrete_Floor

should return the material given properly.

Ensure that the Materials enum contains all the materials. (can tab through and compare to latest alpha/beta)

Changelog

Additional comments

[CKBoulter]

Fixes issue as now allows you to pull the material, however, it now removes those beginning with "_" when tabbing for materials list.

[Tom-Kingstone]

Fixes issue as now allows you to pull the material, however, it now removes those beginning with "_" when tabbing for materials list.

this is likely due to python marking any values beginning with _ as private... I'm not sure what character to start the identifier with if it begins with a number if not _. "a_" would allow them to be visible, but not too sure on the UX of a_12_in_Normalweight_Concrete_Floor.

[jamesramsden-bh]

See commented code for requested changes

[CKBoulter]

Changes worked. All materials which previously were hidden due to beginning with a _ are now showing in materials list beginning with "Material" in place of _. Pulls successfully.

[Tom-Kingstone]

@BHoMBot check required

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 146 requests in the queue ahead of you.

[Tom-Kingstone]

@BHoMBot check compliance
@BHoMBot check unit-tests

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check unit-tests

There are 72 requests in the queue ahead of you.

[Tom-Kingstone]

@BHoMBot check ready-to-merge

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check ready-to-merge

There are 70 requests in the queue ahead of you.

[jamesramsden-bh]

Requested changes now implemented

[Tom-Kingstone]

@BHoMBot check ready-to-merge

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check ready-to-merge

There are 153 requests in the queue ahead of you.