-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve adapter speed by caching LBT Python environment on construction #172
Improve adapter speed by caching LBT Python environment on construction #172
Conversation
@Tom-Kingstone to confirm, the following actions are now queued:
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot check required |
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and tests passed, happy to approve
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code and looks good, nice work @Tom-Kingstone
NOTE: Depends on
Issues addressed by this PR
Closes #171
Added private
m_environment
property toLadybugToolsAdapter
and updated usage in execute commands.Also install BasePythonEnvironment before LBT environment for better UX
Test files
Changelog
Additional comments