Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve adapter speed by caching LBT Python environment on construction #172

Merged

Conversation

Tom-Kingstone
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone commented Jan 31, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #171

Added private m_environment property to LadybugToolsAdapter and updated usage in execute commands.
Also install BasePythonEnvironment before LBT environment for better UX

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Jan 31, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Jan 31, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core

Copy link

bhombot-ci bot commented Jan 31, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check installer
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 31, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check installer
  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Jan 31, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Jan 31, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 31, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 31, 2024

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 31, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 31, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@albinber albinber self-requested a review February 1, 2024 13:59
Copy link

@albinber albinber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and tests passed, happy to approve

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Feb 1, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Feb 1, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and looks good, nice work @Tom-Kingstone

@FraserGreenroyd FraserGreenroyd merged commit c39f290 into develop Feb 1, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#171-AdapterPythonEnvironment branch February 1, 2024 14:56
@FraserGreenroyd FraserGreenroyd changed the title Adapter: made LBT PythonEnvironment a private property Improve adapter speed by caching LBT Python environment on construction Feb 1, 2024
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapter: Make python environment a private property
3 participants