Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in dropdowns unlocked #677

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

pawelbaran
Copy link
Member

NOTE: Depends on

BHoM/BHoM_UI#450

Issues addressed by this PR

Closes #

Test files

See BHoM/BHoM_UI#450

Changelog

Additional comments

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as part of the review for BHoM/BHoM_UI#450

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

1 similar comment
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 9 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 3 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_UI

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_UI

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

There are 16 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

@pawelbaran just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_UI

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 16, 2023

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@adecler adecler merged commit f88046a into develop Feb 16, 2023
@adecler adecler deleted the BHoM_UI-#449-SearchInDropdowns branch February 16, 2023 12:34
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants