Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to get unique Canvas IDs for analytics #664

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Oct 19, 2022

NOTE: Depends on

BHoM/BHoM_UI#429

Issues addressed by this PR

Closes #

Test files

Changelog

Additional comments

When trying to do project analytics per canvas, the doc.DocumentID wasn't unique between canvases, so doing a new canvas or loading in a saved script would give the same DocumentID. Instead, there is a unique RuntimeID available instead, but that is just a ulong rather than a more unique GUID, and resets each time you load Grasshopper. Therefore, the decision has been made to use that to generate unique IDs per canvas for the analytics, rather than the DocumentID.

@FraserGreenroyd FraserGreenroyd self-assigned this Oct 19, 2022
@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Oct 19, 2022
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 1 requests in the queue ahead of you.

Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for multi document/file analytics. Issue with setting project Id on documents to avoid popup to be resolved in another PR. Approved.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 9 requests in the queue ahead of you.

Copy link

@EKAdebo EKAdebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analytics pop up appears when you change scripts in Grasshopper or Excel workbooks.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 12 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge
  • check copyright-compliance

There are 27 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is copyright-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8987860273

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8987115997

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8987860273

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8987115997

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

@FraserGreenroyd I have now provided a passing check on reference 8987860273 as requested.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 19, 2022

@FraserGreenroyd I have now provided a passing check on reference 8987115997 as requested.

@FraserGreenroyd FraserGreenroyd merged commit c6c98c8 into main Oct 19, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#428-AnalyticsPerFile branch October 19, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants