-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to get unique Canvas IDs for analytics #664
Conversation
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for multi document/file analytics. Issue with setting project Id on documents to avoid popup to be resolved in another PR. Approved.
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analytics pop up appears when you change scripts in Grasshopper or Excel workbooks.
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
The check |
The check |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 27 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is copyright-compliance. If you are providing dispensation on this occasion, please reply with:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is documentation-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8987860273 |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8987115997 |
@FraserGreenroyd I have now provided a passing check on reference |
@FraserGreenroyd I have now provided a passing check on reference |
NOTE: Depends on
BHoM/BHoM_UI#429
Issues addressed by this PR
Closes #
Test files
Changelog
Additional comments
When trying to do project analytics per canvas, the
doc.DocumentID
wasn't unique between canvases, so doing a new canvas or loading in a saved script would give the sameDocumentID
. Instead, there is a uniqueRuntimeID
available instead, but that is just aulong
rather than a more unique GUID, and resets each time you load Grasshopper. Therefore, the decision has been made to use that to generate unique IDs per canvas for the analytics, rather than theDocumentID
.