-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed which enum UnitType to use for NodeDisplacements #290
Changed which enum UnitType to use for NodeDisplacements #290
Conversation
Changed from length to disp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected and code changes look good :)
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
Changed what UnitType (LENGTH to DISP) was being used when pulling node displacements from GSA to fix bug where results were pulled in mm instead of m.
NOTE: Depends on
Issues addressed by this PR
Closes #289
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23290-read-node-displacements-gives-wrong-unit?csf=1&web=1&e=BJnL5s
Changelog
Additional comments