Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed which enum UnitType to use for NodeDisplacements #290

Merged

Conversation

TosteSkDa
Copy link
Contributor

@TosteSkDa TosteSkDa commented Mar 24, 2023

Changed what UnitType (LENGTH to DISP) was being used when pulling node displacements from GSA to fix bug where results were pulled in mm instead of m.

NOTE: Depends on

Issues addressed by this PR

Closes #289

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23290-read-node-displacements-gives-wrong-unit?csf=1&web=1&e=BJnL5s

Changelog

Additional comments

@TosteSkDa TosteSkDa added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Mar 24, 2023
@TosteSkDa TosteSkDa added this to the BHoM 6.2 β MVP milestone Mar 24, 2023
@TosteSkDa TosteSkDa self-assigned this Mar 24, 2023
@TosteSkDa TosteSkDa linked an issue Mar 24, 2023 that may be closed by this pull request
Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and code changes look good :)

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 3, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 3, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 3, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 3, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning

@IsakNaslundBh IsakNaslundBh added type:bug Error or unexpected behaviour and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Apr 4, 2023
@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 4, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 325e6d4 into develop Apr 4, 2023
@IsakNaslundBh IsakNaslundBh deleted the #289-read-node-displacements-gives-wrong-unit branch April 4, 2023 07:11
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read node displacements gives wrong unit
3 participants