Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull timber material from gsa 10 wrong value #288

Merged

Conversation

johannaisak
Copy link
Contributor

@johannaisak johannaisak commented Mar 23, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #287

Shear modulus and thermal coefficient value fix - swapped indices

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23288-pull-timber-material-from-gsa-10-wrong-value?csf=1&web=1&e=HMgtjQ

Changelog

Additional comments

@johannaisak johannaisak added the type:bug Error or unexpected behaviour label Mar 23, 2023
@johannaisak johannaisak added this to the BHoM 6.1 β MVP milestone Mar 23, 2023
@johannaisak johannaisak linked an issue Mar 23, 2023 that may be closed by this pull request
@johannaisak johannaisak self-assigned this Mar 23, 2023
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes.

Have tested with test script, which proves the changes are right.

ode changes are looking great as well.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 24, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 24, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 24, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 24, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit a5372c7 into develop Mar 24, 2023
@FraserGreenroyd FraserGreenroyd deleted the #287-pull-timber-material-from-gsa-10-wrong-value branch March 24, 2023 16:28
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull timber material from GSA 10 wrong value
3 participants