-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull timber material from gsa 10 wrong value #288
Pull timber material from gsa 10 wrong value #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the changes.
Have tested with test script, which proves the changes are right.
ode changes are looking great as well.
@IsakNaslundBh to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #287
Shear modulus and thermal coefficient value fix - swapped indices
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23288-pull-timber-material-from-gsa-10-wrong-value?csf=1&web=1&e=HMgtjQ
Changelog
Additional comments