Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read thickness fix #286

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

johannaisak
Copy link
Contributor

@johannaisak johannaisak commented Mar 16, 2023

Handles if thickness is written as number or number(unit) for both GSA10.1 and GSA 8.7

NOTE: Depends on

Issues addressed by this PR

Closes #285

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23286-Pull-FE-meshes-in-GSA101?csf=1&web=1&e=YH3NIy

Changelog

Additional comments

Handles if thickness is written as number or number(unit) for both GSA10.1 and GSA 8.7
@johannaisak johannaisak added the type:bug Error or unexpected behaviour label Mar 16, 2023
@johannaisak johannaisak added this to the BHoM 6.1 β MVP milestone Mar 16, 2023
@johannaisak johannaisak self-assigned this Mar 16, 2023
@johannaisak johannaisak linked an issue Mar 16, 2023 that may be closed by this pull request
@johannaisak johannaisak changed the title Thickness fix Read thickness fix Mar 16, 2023
Copy link
Contributor

@TosteSkDa TosteSkDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for both GSA8.7 and 10.1. Pull works perfectly. Checked pulled output from GSA and thickness matches. Code looks good.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 15 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2023

Please be advised that the check with reference 12110963219 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 300 additional annotations waiting, made up of 300 errors and 0 warnings.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 114 requests in the queue ahead of you.

@Chrisshort92
Copy link

@FraserGreenroyd can you merge this PR please?

@FraserGreenroyd FraserGreenroyd merged commit 1deffb0 into develop Mar 21, 2023
@FraserGreenroyd FraserGreenroyd deleted the #285-Pull-FE-meshes-in-GSA101 branch March 21, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE Meshes pull error in GSA10.1
4 participants