-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read thickness fix #286
Read thickness fix #286
Conversation
Handles if thickness is written as number or number(unit) for both GSA10.1 and GSA 8.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for both GSA8.7 and 10.1. Pull works perfectly. Checked pulled output from GSA and thickness matches. Code looks good.
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 15 requests in the queue ahead of you. |
Please be advised that the check with reference 12110963219 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 300 additional annotations waiting, made up of 300 errors and 0 warnings. |
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 114 requests in the queue ahead of you. |
@FraserGreenroyd can you merge this PR please? |
Handles if thickness is written as number or number(unit) for both GSA10.1 and GSA 8.7
NOTE: Depends on
Issues addressed by this PR
Closes #285
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23286-Pull-FE-meshes-in-GSA101?csf=1&web=1&e=YH3NIy
Changelog
Additional comments