Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GeterateIdString -> GenerateIDString #279

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #260

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Feb 9, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Feb 9, 2023
Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty small changes. Makes sense.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check core

1 similar comment
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

There are 4 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only name change of internal method. If Bot is able to pass all checks and compile, I am fine with this going in.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 13, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 3 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 13, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 13, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 13, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 13, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 52b30f5 into develop Feb 13, 2023
@FraserGreenroyd FraserGreenroyd deleted the GSA_Toolkit-#260-Typo branch February 13, 2023 10:35
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in method name GeterateIdString
3 participants