Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of caching system in base adapter #277

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jan 19, 2023

NOTE: Depends on

BHoM/BHoM_Adapter#337
intentionally using different branch names to let the Adapter PR be merged separately.

Issues addressed by this PR

Closes #276

Make use of the Caching system added to the Base adapter. Aim for this to speed up the push process, especially for higher level objects.

Also includes a tweak to read of materials to aim to make it fit with new system. ID for materials for GSA10 now includes material type, as that is required to differentiate between different material types

Had to change some dictionaries to int keys instead of string to align with the actual adapter ids, which lead to having to make minor updates to some convert methods. Also fixed some minor copy-paste typos.

Test files

Changelog

Additional comments

Also includes a tweak to read of materials to aim to make it fit with new system.
ID for materials for GSA10 now includes material type, as that is required to differentiate between different material types
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jan 19, 2023
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 19, 2023
alelom
alelom previously approved these changes Jan 19, 2023
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Tested with create-read script and works well.

Update various parts of the material handling to fit with the new framework.
Main fixes to make sure ids of materials are set as "MaterialType:Number" for GSA 10, as GSA 10 has multiple material tables
Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a couple of old projects with different materials and fabric, all seems to work as expected.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 25, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 15 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check ready-to-merge

1 similar comment
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 27, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning
  • check ready-to-merge

There are 16 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 27, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning
  • check ready-to-merge

There are 21 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit 3b7cc9b into develop Jan 27, 2023
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-#276-MakeUseOfCachingSystem branch January 27, 2023 11:03
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of Caching system
3 participants