-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of caching system in base adapter #277
Make use of caching system in base adapter #277
Conversation
Also includes a tweak to read of materials to aim to make it fit with new system. ID for materials for GSA10 now includes material type, as that is required to differentiate between different material types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good. Tested with create-read script and works well.
Update various parts of the material handling to fit with the new framework. Main fixes to make sure ids of materials are set as "MaterialType:Number" for GSA 10, as GSA 10 has multiple material tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a couple of old projects with different materials and fabric, all seems to work as expected.
@IsakNaslundBh to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 15 requests in the queue ahead of you. |
1 similar comment
@IsakNaslundBh to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 21 requests in the queue ahead of you. |
NOTE: Depends on
BHoM/BHoM_Adapter#337
intentionally using different branch names to let the Adapter PR be merged separately.
Issues addressed by this PR
Closes #276
Make use of the Caching system added to the Base adapter. Aim for this to speed up the push process, especially for higher level objects.
Also includes a tweak to read of materials to aim to make it fit with new system. ID for materials for GSA10 now includes material type, as that is required to differentiate between different material types
Had to change some dictionaries to int keys instead of string to align with the actual adapter ids, which lead to having to make minor updates to some convert methods. Also fixed some minor copy-paste typos.
Test files
Changelog
Additional comments