File_Adapter: added missing copy local and build event for System.Management.Automation.dll
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement.Automation`
System.Management.AutomationSystem.Management.Automation.dll
Dmamedova
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Because I don't have Visual Studio installed yet, with @alelom we manually copied the missing assembly in the BHoM installation folder and that fixed the issue for me. The File_Adapter is now correctly doing the Pull, while before it was giving me an error of missing assembly. We have run test scripts and they work correctly.
|
The combined reviews of @michaelhoehn and @Dmamedova make this PR safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #196
Added missing copy local and build event for
System.Management.Automation.dll, from its original location sourced fromC:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Management.Automation\v4.0_3.0.0.0__31bf3856ad364e35\System.Management.Automation.dll.Test files
Follow the File_Toolkit testing procedure
Changelog
Additional comments