Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.1 Deployment #380

Merged
merged 3 commits into from
Mar 23, 2023
Merged

6.1 Deployment #380

merged 3 commits into from
Mar 23, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd FraserGreenroyd self-requested a review March 13, 2023 18:11
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 103 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Mar 13, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 103 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

MERGE REPORT - 2023-03-19 15:43.

DETAILS:
This pull request can be merged or not merged without impact on any of its upstream dependencies..

@travispotterBH
Copy link

Tested with Beta BHoM_6.1.230320.beta.0 and testing procedure. Modified testing procedure to include testing of VBA functions calling BHoM methods.

No failures. Approved.

travispotterBH
travispotterBH approved these changes Mar 20, 2023
View reviewed changes
Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per above statement.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 21, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 21, 2023

MERGE REPORT - 2023-03-21 15:00.

DETAILS:
This pull request can be merged or not merged without impact on any of its upstream dependencies..

@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge and removed type:feature New capability or enhancement labels Mar 21, 2023
FraserGreenroyd
FraserGreenroyd approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am satisfied with the procedure used by @travispotterBH for this pull request and have checked the dependencies and am happy for this toolkit to be deployed to the 6.1 beta.

@FraserGreenroyd FraserGreenroyd added type:feature New capability or enhancement and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Mar 21, 2023
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

2 similar comments
@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 237 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling

There are 348 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 421 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 22, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 493 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: documentation-compliance, dataset-compliance, ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 23, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 8ee9bb9 into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@travispotterBH travispotterBH travispotterBH approved these changes

Assignees

@bhombot-ci bhombot-ci[bot]

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FraserGreenroyd @travispotterBH @BHoMBot