Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum loading bug #364

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Fix enum loading bug #364

merged 2 commits into from
Sep 29, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #363

Test files

N/A - test steps instead:

  1. Create an Excel file with a BHoM enum object.
  2. Save the file
  3. Change the enum which was added to the Excel sheet by adding or removing a value
  4. Recompile the enum
  5. Reopen the Excel file previously made
  6. Verify the dropdown is now updated with the changed values - this did not happen on main

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Sep 29, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Sep 29, 2022
@FraserGreenroyd
Copy link
Contributor Author

FraserGreenroyd commented Sep 29, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 7 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 5 requests in the queue ahead of you.

Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a call with Fraser. Looks good to go.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 29, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 8ce7467 into main Sep 29, 2022
@FraserGreenroyd FraserGreenroyd deleted the Excel_UI-#363-EnumLoadingBug branch September 29, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enums Not Updating
2 participants