Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the duplicate dependency in the nuspec file #83

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

adecler
Copy link
Member

@adecler adecler commented Jul 3, 2024

Issues addressed by this PR

Closes #82

See issue for more details.

@pawelbaran, I was not too sure who else to add as a reviewer. It is a fairly straight forward fix but happy to jump in a call if you need more details.

@adecler adecler added the type:bug Error or unexpected behaviour label Jul 3, 2024
@adecler adecler requested a review from pawelbaran July 3, 2024 16:38
@adecler adecler self-assigned this Jul 3, 2024
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense - the code builds and still works, duplicate removed. Happy to approve!

@adecler
Copy link
Member Author

adecler commented Jul 4, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Jul 4, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 234 requests in the queue ahead of you.

@adecler
Copy link
Member Author

adecler commented Jul 4, 2024

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jul 4, 2024

@adecler to confirm, the following actions are now queued:

  • check copyright-compliance

There are 2 requests in the queue ahead of you.

@adecler
Copy link
Member Author

adecler commented Jul 4, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jul 4, 2024

@adecler to confirm, the following actions are now queued:

  • check ready-to-merge

@adecler adecler merged commit 79ed511 into develop Jul 4, 2024
10 checks passed
@adecler adecler deleted the Excel_Toolkit-#82-FixNuspecFile branch July 4, 2024 12:49
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet package failed to create
2 participants