Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional push config properties to support Embodied Carbon report #12

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

adecler
Copy link
Member

@adecler adecler commented Feb 21, 2023

@adecler adecler added the type:feature New capability or enhancement label Feb 21, 2023
@adecler adecler self-assigned this Feb 21, 2023
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run through the test scenario that identified this work to be required and the produced outcome is suitable. I have reviewed the code changes and they look sensible for the code being introduced, so I'm happy for this to go off to alpha.

@FraserGreenroyd
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 8 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check versioning

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 45edd07 into develop Feb 27, 2023
@FraserGreenroyd FraserGreenroyd deleted the EmbodiedCarbon_Toolkit-#5-ExcelReport branch February 27, 2023 14:37
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants