-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Get Joint Velocities #469
Add Get Joint Velocities #469
Conversation
Hi, @GCRA101 , the links you have attached above don not work. Can you update them then I can look to review this PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality has been tested and confirmed with the test scripts provided. PR Approved.
@BHoMBot bot check required |
@Chrisshort92 to confirm, the following actions are now queued:
|
@BHoMBot check copyright-compliance |
@GCRA101 to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to test the functionality but will rely on @Chrisshort92's test.
Code looks fine and aligns well with the other results with a similar type.
Issues addressed by this PR
Closes #461
ETABS Toolkit now can allow to extract joint velocity outputs from ETABS.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/s/BHoM/EbBh2Bp2-ClMnlW9wICmtawB01iZK2MJQ6E6n2egPAJaLA?e=lw9gCH
ETABS File
https://burohappold.sharepoint.com/:u:/s/BHoM/EWZD6lHguYFCqraF_rtmuJUBKGwKb-gREeNW-2wv3FDO8Q?e=vdDmlF
Changelog