Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get Joint Velocities #469

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Aug 14, 2024

Issues addressed by this PR

Closes #461

GH Script - Success - After Pull Request

ETABS Outputs - Success

ETABS Toolkit now can allow to extract joint velocity outputs from ETABS.

Test files

Grasshopper File
https://burohappold.sharepoint.com/:u:/s/BHoM/EbBh2Bp2-ClMnlW9wICmtawB01iZK2MJQ6E6n2egPAJaLA?e=lw9gCH
ETABS File
https://burohappold.sharepoint.com/:u:/s/BHoM/EWZD6lHguYFCqraF_rtmuJUBKGwKb-gREeNW-2wv3FDO8Q?e=vdDmlF

Changelog

  • Added ReadNodeVelocity Method to retrieve Abs Joint Velocities from ETABS

@GCRA101 GCRA101 self-assigned this Aug 14, 2024
@GCRA101 GCRA101 added the type:feature New capability or enhancement label Aug 14, 2024
@GCRA101 GCRA101 added this to the BHoM 7.3 β MVP milestone Aug 14, 2024
@Chrisshort92
Copy link
Contributor

Hi, @GCRA101 , the links you have attached above don not work. Can you update them then I can look to review this PR. Thanks.

@Chrisshort92
Copy link
Contributor

Hi, @GCRA101 , the links you have attached above don not work. Can you update them then I can look to review this PR. Thanks.

@GCRA101 , Actually they do work if I copy the URL into the browser, will get on with testing these.

Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality has been tested and confirmed with the test scripts provided. PR Approved.

@Chrisshort92
Copy link
Contributor

Chrisshort92 commented Aug 30, 2024

@BHoMBot bot check required

Copy link

bhombot-ci bot commented Aug 30, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 4, 2024

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Sep 4, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check copyright-compliance

@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 4, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 4, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to test the functionality but will rely on @Chrisshort92's test.

Code looks fine and aligns well with the other results with a similar type.

@peterjamesnugent peterjamesnugent merged commit 0a69588 into develop Sep 4, 2024
10 checks passed
@peterjamesnugent peterjamesnugent deleted the ETABS_Toolkit-#461-AddGetJointVelocities branch September 4, 2024 19:13
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Feature to Retrieve Joint Velocities
3 participants