Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Set Get Point Displacement Loads #467

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Add Set Get Point Displacement Loads #467

merged 3 commits into from
Sep 4, 2024

Conversation

GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Aug 14, 2024 •
edited
Loading

Issues addressed by this PR

Closes #459

It is now possible to push and pull Point Displacement Loads to/from ETABS (see below)

GH Script - Success

ETABS Outputs - Success

Test files

Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23467-AddSetGetPointDisplacementLoad/Test%20Script.gh?csf=1&web=1&e=L6zLU9
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23467-AddSetGetPointDisplacementLoad/Test%20Etabs%20Model.EDB?csf=1&web=1&e=UJENuT

Changelog

  • Added SetLoad Method for Point Displacement Loads
  • Added ReadLoad Method for Point Displacement Loads

@GCRA101 GCRA101 added the type:feature New capability or enhancement label Aug 14, 2024
@GCRA101 GCRA101 added this to the BHoM 7.3 β MVP milestone Aug 14, 2024
@GCRA101 GCRA101 self-assigned this Aug 14, 2024
@Chrisshort92
Copy link
Contributor

@GCRA101 , I cannot replicate this in ETABS. The object pull correctly and the push function states success but there are no point displacements in ETABS for either of the selected joints. Let's review this one.

Chrisshort92
Chrisshort92 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved now that functionality can be verified. Push was not previously taking place due to Etabs model being locked. Push can only take plush with an unlocked model. BHoM functionality working as expected. Approved.

@Chrisshort92
Copy link
Contributor

@BHoMBot check required

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 4, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 4, 2024

@BHoMBot check copyright-compliance

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 4, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check copyright-compliance

@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 4, 2024

@BHoMBot check ready-to-merge

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 4, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent
Copy link
Member

@BHoMBot check required

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 4, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member

@BHoMBot check copyright-compliance

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 4, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

There are 1 requests in the queue ahead of you.

peterjamesnugent
peterjamesnugent approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rely on @Chrisshort92's review for functionality test - happy to approve from a code perspective.

@peterjamesnugent
Copy link
Member

@BHoMBot check ready-to-merge

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Sep 4, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent peterjamesnugent merged commit 2011ed3 into develop Sep 4, 2024
10 checks passed
@peterjamesnugent peterjamesnugent deleted the ETABS_Toolkit-#459-AddSetGetPointDisplLoads branch September 4, 2024 20:01
@BHoMBot BHoMBot mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chrisshort92 Chrisshort92 Chrisshort92 approved these changes

@peterjamesnugent peterjamesnugent peterjamesnugent approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@GCRA101 GCRA101

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 7.3 β MVP
Development

Successfully merging this pull request may close these issues.

Add Set/Get Point Displacement Loads
3 participants
@GCRA101 @Chrisshort92 @peterjamesnugent