-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of caching system in base adapter #418
Make use of caching system in base adapter #418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built the branch and tested the functionality with the test files. All seems ok. Code not reviewed.
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check required |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of code changes only.
NOTE: Depends on
BHoM/BHoM_Adapter#337
intentionally using different branch names to let the Adapter PR be merged separately.
Issues addressed by this PR
Closes #417
Make use of the Caching system added to the Base adapter. Aim for this to speed up the push process, especially for higher level objects.
Test files
Usual test file for Push/Pull:
The testing should simply verify that things work as good as usual.
This PR only makes backend improvements to the Adapter and should not affect existing workflows.
Changelog
Additional comments