Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of caching system in base adapter #418

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jan 18, 2023

NOTE: Depends on

BHoM/BHoM_Adapter#337
intentionally using different branch names to let the Adapter PR be merged separately.

Issues addressed by this PR

Closes #417

Make use of the Caching system added to the Base adapter. Aim for this to speed up the push process, especially for higher level objects.

Test files

Usual test file for Push/Pull:

The testing should simply verify that things work as good as usual.
This PR only makes backend improvements to the Adapter and should not affect existing workflows.

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jan 18, 2023
@IsakNaslundBh IsakNaslundBh requested a review from alelom January 18, 2023 15:13
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 18, 2023
Copy link

@hmoubarak hmoubarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built the branch and tested the functionality with the test files. All seems ok. Code not reviewed.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 8 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 28, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of code changes only.

@IsakNaslundBh IsakNaslundBh merged commit 4e848ca into develop Feb 28, 2023
@IsakNaslundBh IsakNaslundBh deleted the Etabs_Toolkit-#417-MakeUseOfCachingSystemInBaseAdapter branch February 28, 2023 09:23
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of Caching system
3 participants